Add RefinedGridInfo class (for potential Hovmoller/zonal mean support)#165
Merged
trexfeathers merged 22 commits intoSciTools:mainfrom Mar 30, 2022
Merged
Add RefinedGridInfo class (for potential Hovmoller/zonal mean support)#165trexfeathers merged 22 commits intoSciTools:mainfrom
trexfeathers merged 22 commits intoSciTools:mainfrom
Conversation
Codecov Report
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Contributor
|
Lint failure: see SciTools/iris#4668 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
stephenworsley
force-pushed
the
refined_grid_info
branch
from
648b59c to
375bc4d
Compare
trexfeathers
requested changes
Mar 30, 2022
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Hi @stephenworsley, here's half a review (pre force-push).
trexfeathers
requested changes
Mar 30, 2022
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Apparently I was closer to finishing than I thought! Here's the final comment.
trexfeathers
approved these changes
Mar 30, 2022
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Excellent work as usual @stephenworsley!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the RefinedGridInfo class. This class is designed to better handle grids with particularly large cells. These grids would typically have large innacuracies due to the difference between lines of latitudes and great circles, and in some cases, e.g. full latitude/longitude bounds, these could not even be represented in ESMF. This class solves these problems by having their ESMF representations be a "refinement" of the original grid by either increasing the longitude resolution by a desired factor, or else by increasing the latitude resolution sufficiently to be representable. This becomes especially usefull in the case of deriving Hovmoller plots.